cshuo commented on code in PR #19502:
URL: https://github.com/apache/hudi/pull/19502#discussion_r3732972266
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/LsmFileGroupReaderBasedMergeHandle.java:
##########
@@ -63,9 +64,9 @@ public LsmFileGroupReaderBasedMergeHandle(HoodieWriteConfig
config, String insta
Map<String, HoodieRecord<T>>
keyToNewRecords, String partitionPath, String fileId,
HoodieBaseFile dataFileToBeMerged,
TaskContextSupplier taskContextSupplier,
Option<BaseKeyGenerator>
keyGeneratorOpt) {
- this(config, instantTime, hoodieTable, keyToNewRecords.values().stream()
- .sorted(Comparator.comparing(HoodieRecord::getRecordKey)).iterator(),
partitionPath, fileId,
- taskContextSupplier, dataFileToBeMerged, keyGeneratorOpt);
+ this(config, instantTime, hoodieTable,
Review Comment:
Confirmed that no built-in path (including reflection) uses this
constructor. The LSM write path uses the iterator constructor, while compaction
uses the `CompactionOperation` constructor. I’ll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
