deepakpanda93 commented on PR #19555: URL: https://github.com/apache/hudi/pull/19555#issuecomment-5219134005
Widened the scope in c6f67962b2a0, taking up the "happy to widen if preferred" offer in the description. Now 6 files instead of 2. ### Why Auditing the other versioned copies showed **every one of the ten carries the identical broken example** — `(id, name, dt, hh)` with `PARTITIONED BY (dt)`. The 0.x and 1.x sections differ only by trailing whitespace on two lines, so this is one defect duplicated ten times, not a next-only problem. That puts it in the correction bucket rather than the addition bucket. The next-plus-current convention (#19473) is for additive guidance; a *wrong* example that silently corrupts data is closer to #19459, which backported a stale default to every affected 1.x version. The cause is Spark's partition-column reordering rather than anything Hudi-version-specific, so the example is wrong on every release that ships it, and those pages are all live. ### What changed The corrected example and the caution are now applied to **next, 1.2.0, 1.1.1, 1.0.2, 1.0.1 and 1.0.0**. All six `Create partitioned table` sections are byte-identical after the change. **0.14.0/1/2 and 0.15.0/1 are deliberately left alone** as end-of-life — flagged here rather than left as a silent gap, since they carry the same broken example. Happy to include them if the project would rather every live page be correct. ### Verified on 1.0.2 before backporting Since the change now touches older releases, I re-ran the decisive pair against `hudi-spark3.5-bundle_2.12:1.0.2` rather than carrying the 1.2.0 result across by inference: | `PARTITIONED BY` | Stored column order | Positional insert `1,'n1','2024-01-01','10'` | |---|---|---| | `(dt)` | `id, name, `**`hh, dt`** | :x: `dt='10'`, `hh='2024-01-01'` — silent, exit 0 | | `(dt, hh)` | `id, name, dt, hh` (unchanged) | :white_check_mark: `dt='2024-01-01'`, `hh='10'` | Identical to 1.2.0. (The first 1.0.2 run also threw an unrelated `FileAlreadyExistsException` from the metadata-table writer on local FS; it retried and the write completed. I re-ran with `hoodie.metadata.enable=false` for a clean result, which is what is quoted above.) ### Also Bumped `last_modified_at` on the two copies that carry a value — I had missed that in the first commit. The four older copies have the field present but blank in this repo, so I left them blank rather than invent dates for historical releases. Build is clean with the warning set byte-identical to a baseline of the same base commit. Rendering was checked on `/docs/sql_ddl`, `/docs/next/sql_ddl`, and the `1.1.1`, `1.0.2`, `1.0.1`, `1.0.0` pages — all show `PARTITIONED BY (dt, hh);` with the caution; `0.15.1` still shows the old form, as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
