linliu-code commented on PR #675:
URL: https://github.com/apache/hudi-rs/pull/675#issuecomment-5232833658
Closing: integrated into #673.
Cherry-picked as 50f849e so the merge-on-read work sits on one line. It is
not a
byte-identical replay -- this PR and the read-option sweep both extended
`gold_parity_tests.rs`, so the two had to be merged rather than stacked:
`merge_by_position` now folds into `options_for` alongside the option-case
settings, `sweep` returns a `SweepResult`, and the duplicate-key defect moved
into the engine-aware known list. Option cases stay on the key-merge path,
since their gold was taken without record positions.
Both tests from this PR pass unchanged on the tip:
compared 62 fixtures -- v2+positions 62; 7 without gold
merging_by_position_and_by_key_disagree_on_duplicate_record_keys ... ok
Review it in #673, or in #660 for the whole line squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
