deepakpanda93 commented on code in PR #19569:
URL: https://github.com/apache/hudi/pull/19569#discussion_r3747954106
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -292,6 +305,17 @@ object DefaultSource {
private val log = LoggerFactory.getLogger(classOf[DefaultSource])
+ /**
+ * What to do instead, appended to every rejection in the 3-arg
createRelation so the user is
Review Comment:
Fair, reworded — though not to the suggested text, because that names the
wrong overload.
`createRelation(sqlContext, parameters)` is the 2-arg one. The constant is
used in the 3-arg
`createRelation(sqlContext, optParams, schema)`, so I have used that
signature:
```scala
/**
* What to do instead, appended to every rejection in
* `createRelation(sqlContext, optParams, schema)` so the user is never told
only what does not
* work. ...
*/
```
Same intent as your suggestion, no overload counting, and it points at the
method that actually
throws.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
