hudi-agent commented on code in PR #19580:
URL: https://github.com/apache/hudi/pull/19580#discussion_r3756864161
##########
packaging/hudi-integ-test-bundle/pom.xml:
##########
@@ -139,10 +139,7 @@
<include>org.apache.spark:spark-streaming-kafka-0-10_${scala.binary.version}</include>
<include>com.101tec:zkclient</include>
- <include>org.apache.hive:hive-common</include>
- <include>org.apache.hive:hive-service</include>
- <include>org.apache.hive:hive-jdbc</include>
- <include>org.apache.hive:hive-exec</include>
+
<include>com.yammer.metrics:metrics-core</include>
Review Comment:
🤖 This shade `<artifactSet><includes>` is an allow-list, so dropping the
four `org.apache.hive:*` includes means those classes are no longer packaged
into the bundle even though they still resolve transitively via
`hudi-hive-sync`. But the bundle still includes `hudi-hive-sync` (line 84) and
`hudi-integ-test` (line 88), and their *main* code references Hive at runtime —
e.g. `HiveServiceProvider` imports `org.apache.hive.service.server.HiveServer2`
(hive-service), and `HiveSyncNode`/`HiveSyncTool` pull in
hive-jdbc/metastore/common. Won't the test-suite DAGs that run Hive sync /
start the embedded HiveServer2 from this jar now hit `NoClassDefFoundError`,
unless Hive is guaranteed on the runtime classpath externally? Could you
confirm how the integ-test-bundle is launched (is Hive provided by the
container/spark classpath), or whether these Hive includes still need to stay?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
