danny0405 commented on code in PR #19211:
URL: https://github.com/apache/hudi/pull/19211#discussion_r3771243369
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -673,7 +673,8 @@ private MergeOnReadInputFormat mergeOnReadInputFormat(
getParquetConf(this.conf, this.hadoopConf.unwrap()),
this.conf.get(FlinkOptions.READ_UTC_TIMEZONE),
this.internalSchemaManager,
- tableSchema
+ tableSchema,
+ this.conf
Review Comment:
passing around the flag instead of the whole conf.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java:
##########
@@ -201,7 +208,45 @@ protected ClosableIterator<RowData>
initIterator(MergeOnReadInputSplit split) th
HoodieSchema.parse(tableState.getTableSchema()));
final HoodieSchema requiredSchema = HoodieSchemaCache.intern(
HoodieSchema.parse(tableState.getRequiredSchema()));
- return getSplitRowIterator(split, tableSchema, requiredSchema, mergeType,
emitDelete);
+ ClosableIterator<RowData> iter = getSplitRowIterator(split, tableSchema,
requiredSchema, mergeType, emitDelete);
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
