Rajeev-01 commented on code in PR #19596:
URL: https://github.com/apache/hudi/pull/19596#discussion_r3773162099
##########
hudi-hadoop-common/src/main/java/org/apache/parquet/avro/AvroSchemaConverterWithTimestampNTZ.java:
##########
@@ -669,15 +669,11 @@ private static String appendPath(String path, String
fieldName) {
/* Avro <= 1.9 does not support conversions to LocalTimestamp{Micros,
Millis} classes */
private static boolean avroVersionSupportsLocalTimestampTypes() {
- final String avroVersion = getRuntimeAvroVersion();
+ final String avroVersion = HoodieAvroUtils.AVRO_VERSION;
return avroVersion == null
|| !(avroVersion.startsWith("1.7.")
|| avroVersion.startsWith("1.8.")
|| avroVersion.startsWith("1.9."));
}
Review Comment:
Ack. agree with the behavioral change that will intrduce with this PR wrt to
timestamp creation. Will remove this refactor without coupling this with
`HoodieAvroUtils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
