danny0405 commented on code in PR #19205:
URL: https://github.com/apache/hudi/pull/19205#discussion_r3773793842
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3892,6 +3998,8 @@ public HoodieWriteConfig build() {
@VisibleForTesting
public HoodieWriteConfig build(boolean shouldValidate) {
setDefaults();
+ // Before validate(), so the MoR / engine-type checks see the same mode
the built config will.
+ deriveLegacyPopulateMetaFieldsFromMode();
Review Comment:
then just derive the value here, move the method into `setDefaults` and move
the validation into the `validate()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
