danny0405 commented on code in PR #19613: URL: https://github.com/apache/hudi/pull/19613#discussion_r3780484570
########## hudi-native-text-index/src/lib.rs: ########## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +//! Executable storage and scoring contracts for Hudi's proposed native text +//! index. This is intentionally a small prototype, not a production index. + +use std::error::Error; +use std::fmt::{Display, Formatter}; + +pub const SEGMENT_MAGIC: [u8; 8] = *b"HUDIFTS1"; Review Comment: Addressed. I removed the entire hudi-native-text-index crate from this PR. The RFC now assigns Rust readers/builders and Python bindings to Hudi RS, with the main Hudi repository limited to Spark SQL, MDT lifecycle, and the language-neutral format contract. ########## rfc/README.md: ########## @@ -145,3 +145,4 @@ The list of all RFCs can be found here. | 107 | Dynamic Partitioned Cache for Flink upsert | :hammer_and_wrench: `IN PROGRESS` | | 108 | [Multi-dataset incremental reads in Hudi Streamer](./rfc-108/rfc-108.md) | :eyes: `UNDER REVIEW` | | 109 | Hudi Native Vector Index | :eyes: `UNDER REVIEW` | +| 110 | [Native Full-Text Search Index](./rfc-110/rfc-110.md) | :eyes: `UNDER REVIEW` | Review Comment: Addressed. I removed the RFC-110 catalog entry, changed the document to an unnumbered RFC, and moved it to rfc/rfc-full-text-search/. The RFC now states that its number will be reserved through a separate process PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
