linliu-code commented on PR #678: URL: https://github.com/apache/hudi-rs/pull/678#issuecomment-5302881311
Pushed `e2328bb`, a self-review catch on the first commit. Wiring the gate to `Table` made its own docs wrong: they described the producer as "the FFI bridge when the planner enabled the gate" and scoped the gate to "table version < 8 snapshot reads" — the reader-context comment yihua flagged on #660 ([reader_context.rs:126](https://github.com/apache/hudi-rs/pull/660#discussion_r3787843187)), now in the one PR that was meant to resolve it. The version scoping also stopped matching the code. The wiring populates the gate at both reader-construction sites unconditionally, so it applies to incremental reads too. That is intended, not an oversight: Gate 3 only ever *subtracts*, so it cannot admit a block Gate 4 rejected, and a pending instant has no business in an incremental window either. That was an argument, so it is now a test — `test_pass1_gate3_and_the_incremental_window_only_ever_subtract` pins both directions (pending-inside-window excluded, committed-outside-window still excluded). Mutation-checked by implementing the alternative — skip the gate when a range is set — under which it is the **only** failing test in the suite, so nothing else was pinning this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
