SEPURI-SAI-KRISHNA commented on PR #19648:
URL: https://github.com/apache/hudi/pull/19648#issuecomment-5316184263
Thanks — both addressed.
Renamed the test parameter `unsafe` -> `useRowWriterPath`.
On hive-style + slash-separated: the facts are right, but that combination
is rejected at table creation, so it is unreachable rather than divergent —
`HoodieCatalogTable#extraTableConfig` has
`ValidationUtils.checkArgument(!(sqlOptions.contains(HIVE_STYLE_PARTITIONING_ENABLE.key)
&&
sqlOptions.contains(SLASH_SEPARATED_DATE_PARTITIONING.key)), "Table
configs cannot contain both ...")`, matching the config docs ("Cannot be used
together with hive-style
partitioning").
I also would not want to mirror the Avro behavior here: it applies
`replace(char, char)` to the whole `field=value` string, so a partition field
named e.g. `order-date` yields
`order/date=2026/01/05` — an extra spurious directory level. Copying that
would propagate a bug rather than remove a divergence.
Left the behavior as-is and added a comment on
`testHiveStylePartitioningTakesPrecedence` recording that it pins pre-existing
behavior for an unreachable combination, not a claim
about what that combination should produce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
