danny0405 commented on code in PR #19653:
URL: https://github.com/apache/hudi/pull/19653#discussion_r3800418709
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java:
##########
@@ -219,6 +219,14 @@ private static String getClientId(Path path) {
return splits.length > 1 ? splits[1] : INIT_CLIENT_ID;
}
+ /**
+ * Returns a sort key so heartbeat files order numerically instead of
lexicographically.
+ * The base heartbeat file (empty client id) always sorts first.
+ */
+ private static int getClientIdSortKey(String clientId) {
Review Comment:
+1, let's make the CI pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
