deepakpanda93 commented on issue #15306: URL: https://github.com/apache/hudi/issues/15306#issuecomment-5326067753
This issue was reviewed as part of the JIRA-migrated backlog triage and is being closed as stale. The description in full is: *"Some method like parseQuery in HoodieCommonSqlParser is not so commonly used across different spark versions."* That is an observation rather than a task - no goal, no target shape, no definition of done. The JIRA last moved 2022-07-28. More importantly the premise no longer holds. The cross-version variance came from supporting Spark 3.0/3.1/3.2 alongside 3.3, and those were removed by `ef8a7ad4f17a` (PR #11692, contained in `release-1.0.0` and `release-1.2.0`). On master, `HoodieCommonSqlParser.scala:78` is a one-line delegation: ```scala def parseQuery(sqlText: String): LogicalPlan = sparkExtendedParser.parseQuery(sqlText) ``` with the comment at `:75` explaining it - *"SPARK-37266 Added [[parseQuery]] to [[ParserInterface]] in Spark 3.3.0."* With 3.3 as the floor, the method is uniform across every supported version. Closing - there is no version skew left to refactor away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
