zhang-arvin opened a new pull request, #19657: URL: https://github.com/apache/hudi/pull/19657
### Describe the issue this Pull Request addresses Closes #14753 ### Summary and Changelog This PR adds comprehensive test coverage for `TimestampBasedKeyGenerator` in `TestCOWDataSource`, covering scenarios not addressed by the existing minimal test. The existing test only covers `EPOCHMILLISECONDS` with `yyyyMMdd` output format. The following additional timestamp configurations are now tested: - **EPOCHMILLISECONDS with timezone GMT+8:00** — verifies that timezone configuration works correctly - **EPOCHMICROSECONDS** — tests microsecond-precision epoch timestamps - **DATE_STRING with timezone configuration** — tests string-based date parsing with timezone - **SCALAR with hours time unit** — tests scalar timestamp type with hours (complements the existing days-based SCALAR test) Each test case writes data using the datasource API with `partitionBy()` and verifies that the generated partition paths match the expected timestamp-based format. ### Impact none ### Risk Level low This change only expands test coverage and does not modify production code. The risk is limited to test maintenance and expected-value correctness. ### Documentation Update none ### Contributor checklist - [x] Read through [contributor guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [x] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
