hudi-agent commented on code in PR #19665:
URL: https://github.com/apache/hudi/pull/19665#discussion_r3813506612
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/internal/utils/AvroSchemaEvolutionUtils.java:
##########
@@ -363,5 +365,9 @@ public static HoodieSchema
reconcileSchemaRequirements(HoodieSchema sourceSchema
return
convert(SchemaChangeUtils.applyTableChanges2Schema(sourceInternalSchema,
schemaChange), sourceSchema.getFullName());
}
-}
+ public static HoodieSchema reconcileSchemaRequirements(HoodieSchema
sourceSchema, HoodieSchema targetSchema,
Review Comment:
🤖 nit: the 3-arg overload (caller) ends up below the 4-arg method it
delegates to (callee). Could you move it just above the full
`reconcileSchemaRequirements` signature so callers appear before callees,
matching the convention used elsewhere in the class?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
