yihua opened a new pull request, #19695:
URL: https://github.com/apache/hudi/pull/19695

   ### Describe the issue this Pull Request addresses
   
   Closes #19694. Tables below version 10 must persist the deprecated 
`hoodie.populate.meta.fields` boolean derived from `hoodie.meta.fields.mode` 
(#19205) so pre-1.3.0 readers do not fall back to the `true` default and treat 
a selectively populated table as fully populated. The persistence is 
implemented, but the existing v6 assertion resolves through the mode property 
and cannot fail when the raw key is missing, and neither the 
`HoodieTableConfig.create` site nor an actual table version 6 write is covered.
   
   ### Summary and Changelog
   
   Test-only change, no production code.
   
   - `TestHoodieTableMetaClient`: the v6 branch now asserts the raw persisted 
`hoodie.populate.meta.fields` value instead of `populateMetaFields()` (which 
resolves through the mode and passes either way).
   - `TestHoodieTableConfig`: new parameterized test pinning that 
`HoodieTableConfig.create` derives and persists the boolean below version 10 on 
its own; it is called directly with user-supplied properties by the repair 
overwrite props procedure, and a regression confined to it passes the 
builder-path tests.
   - `TestMetaFieldsModeE2E`: new parameterized test writing a table version 6 
table via the Spark datasource for every `MetaFieldsMode`, asserting the 
persisted table version, both raw properties, and the physical meta column 
population.
   
   Verified red/green by mutation: disabling the builder persistence fails the 
strengthened metaclient assertion with `expected: <true> but was: <null>`, and 
disabling only the `create()` branch fails the new `TestHoodieTableConfig` test 
the same way while all previously existing tests stay green.
   
   ### Impact
   
   None, tests only.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to