rahil-c commented on PR #19699: URL: https://github.com/apache/hudi/pull/19699#issuecomment-5364897875
Reviewed as part of a pass over the whole stack; the substantive comments are on #19698 since that is where the materializer seam and the event de-duplication change live, and they apply here too. Nothing GCS-specific to raise. The `updated` column, `bucket` key column and `gs://` prefix are threaded through the same way as their S3 counterparts, and the GCS source is the same three-line constructor swap. One note: `updated` in a GCS `OBJECT_FINALIZE` payload is RFC 3339, which `Instant.parse` handles, so the timestamp path behaves the same as S3's `eventTime` - including the per-object fallback described in the #19698 comment when the value cannot be parsed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
