rangareddy commented on issue #17277: URL: https://github.com/apache/hudi/issues/17277#issuecomment-5365811408
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8281). **Findings: not done on `master`.** The config is unchanged - `hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:184` still defines `TIME_TRAVEL_AS_OF_INSTANT` as an alias of `HoodieCommonConfig.TIMESTAMP_AS_OF`, so the `as of timestamp` value is interpreted as an instant (start) time. Meanwhile incremental query has moved to completion-time semantics - `hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer` works in `startCompletionTime` / `endCompletionTime` throughout - which is exactly the inconsistency described here. One design point worth settling on the ticket before coding: changing the interpretation of `as of timestamp` is a **user-visible semantic change** for queries that already exist. The same wall-clock value would select a different snapshot after the change. That probably needs either a new option or a table/version-gated switch rather than a silent reinterpretation, and deciding which is the real work here. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
