rangareddy commented on issue #17276:
URL: https://github.com/apache/hudi/issues/17276#issuecomment-5365811113
This issue was reviewed as part of the JIRA-migrated backlog triage
(HUDI-8274).
**Findings: still disabled, and the decision this ticket asks for has not
been made.**
Both classes named in the description carry class-level disables on `master`:
-
`hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieSanity.java:40`
- `@Disabled("HUDI-8274")`, plus two method-level `@Disabled` at `:96` and
`:111`
-
`hudi-integ-test/src/test/java/org/apache/hudi/integ/command/ITTestHoodieSyncCommand.java:33`
- `@Disabled("HUDI-8274")`
The ask here is a decision rather than a fix - *"we should revisit them to
see if we can rewrite them to be new integration tests or we can completely
remove them."* Neither happened; they are just skipped, which is the worst of
the three options because the code and its `run_hoodie_generate_app.sh`
dependency are still carried in the tree at zero value.
Given the description already states the functionality is covered by other
functional tests, deleting them and the old generation scripts looks like the
cheaper resolution, but that is a maintainer call. Recording it either way
would close this out.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
