rangareddy commented on issue #17287: URL: https://github.com/apache/hudi/issues/17287#issuecomment-5365814717
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8354). **Findings: not done, and the linked PR is closed without merging.** PR #12131 (`[HUDI-8354] WIP: Have cloud event source use QueryContext`) is **closed and unmerged**, and its title marks it WIP - so it was never a candidate to land. The `status:pr-available` label on this issue is misleading as a result: it suggests a patch is awaiting review when there is none. Worth removing. The two-step plan in the description is the useful part and still stands: 1. migrate the logic under `IncrSourceHelper#generateQueryInfo` into `QueryContext` 2. have `S3EventsHoodieIncrSource` / `GcsEventsHoodieIncrSource` use `QueryContext` instead of `QueryInfo` Since the reference in the description is pinned to an old commit, whoever picks this up should re-derive which pieces of `generateQueryInfo` are still missing from `QueryContext` against current `master` rather than trusting that link. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
