rangareddy commented on issue #17237: URL: https://github.com/apache/hudi/issues/17237#issuecomment-5366112493
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-6571). **Findings: still open, and the description already contains the diagnosis.** The cause is stated precisely: the tests in `ITTestSavepointsCommand` mock only the timeline without creating actual files, but with the metadata table enabled you cannot restore to an arbitrary commit - a base file has to exist before the commit being rolled back. So the tests encode an assumption that MDT invalidated. That makes this a test-design fix rather than a product bug, and it is directly workable as written: the tests need to create real base files at the relevant instants instead of mocking the timeline alone. One thing worth deciding while doing it: whether these should remain integration tests at all. If the point is the interaction between savepoint/restore and MDT file layout, a functional test that writes real files is both cheaper and more reliable than an IT that mocks its way around them. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
