voonhous commented on code in PR #19682:
URL: https://github.com/apache/hudi/pull/19682#discussion_r3828376877
##########
pom.xml:
##########
@@ -128,6 +128,13 @@
<hadoop.version>2.10.2</hadoop.version>
<hive.groupid>org.apache.hive</hive.groupid>
<hive.version>2.3.10</hive.version>
+ <!-- The thrift artifacts the Hive client jars above are compiled against
(Hive 2.3.10
+ bumped libthrift for CVE-2020-13949); keep in lockstep with
hive.version. The spark4
+ profiles override hive.libthrift.version to the libthrift Spark 4.x
itself ships with
+ the same Hive 2.3.10 client, so the pin never downgrades the
Spark-selected version.
+ See #19680. -->
Review Comment:
Good catch, that sentence was garbled. Reworded in #19704 (comment text
only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
