voonhous commented on code in PR #19674:
URL: https://github.com/apache/hudi/pull/19674#discussion_r3834675532
##########
scripts/release/validate_staged_bundles.sh:
##########
@@ -87,7 +87,10 @@ declare -a extensions=("-javadoc.jar" "-javadoc.jar.asc"
"-javadoc.jar.md5" "-ja
declare -a bundles=("hudi-aws-bundle" "hudi-azure-bundle"
"hudi-cli-bundle_2.12" "hudi-cli-bundle_2.13" "hudi-datahub-sync-bundle"
"hudi-flink1.18-bundle" "hudi-flink1.19-bundle" "hudi-flink1.20-bundle"
"hudi-flink2.0-bundle" "hudi-flink2.1-bundle" "hudi-gcp-bundle"
"hudi-hadoop-mr-bundle" "hudi-hive-sync-bundle" "hudi-integ-test-bundle"
-"hudi-kafka-connect-bundle" "hudi-metaserver-server-bundle"
"hudi-presto-bundle"
+"hudi-kafka-connect-bundle" "hudi-metaserver-server-bundle"
+"hudi-native-spark3.4-bundle_2.12" "hudi-native-spark3.5-bundle_2.12"
"hudi-native-spark3.5-bundle_2.13"
Review Comment:
The comment distinguished existence-check from execution:
`validate_staged_bundles.sh` does a `curl --head` per artifact, and at the
reviewed commit nothing downloaded the native jar from staging to run it.
`abd10d3` adds that leg to `packaging/bundle-validation/ci_run.sh`, which
addresses it; the `native_spark/ci_run.sh` reference above is stale now.
One thing to confirm: the only lane that runs the new path
(`validate-bundles` spark3.5 / openjdk17) fails on `abd10d3` with
`UnsatisfiedLinkError: __fprintf_chk: symbol not found`, since the Alpine image
is musl-linked
([job](https://github.com/apache/hudi/actions/runs/32530451230/job/96921282907)).
Could the glibc image land in this PR, or should the native step be gated off
until it does, so the RC lane is not red on day one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
