hudi-agent commented on code in PR #19727:
URL: https://github.com/apache/hudi/pull/19727#discussion_r3849547179
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/commit/BaseDatasetBulkInsertCommitActionExecutor.java:
##########
@@ -140,8 +141,11 @@ public String getCommitActionType() {
protected BulkInsertPartitioner<Dataset<Row>> getPartitioner(boolean
populateMetaFields, boolean isTablePartitioned) {
if (populateMetaFields) {
if (writeConfig.getIndexType() == HoodieIndex.IndexType.BUCKET) {
+ BucketSortBulkInsertPartitioner.validateCustomSortColumns(table, null);
Review Comment:
🤖 nit: passing `null` here to mean "no sort string, just check the config"
is a bit surprising at the call site. Could you add a no-arg overload
`validateCustomSortColumns(HoodieTable table)` that only checks the config
path, so callers don't need to know that `null` is a valid sentinel?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
