voonhous commented on code in PR #19575:
URL: https://github.com/apache/hudi/pull/19575#discussion_r3853273775
##########
hudi-common/src/main/java/org/apache/hudi/common/config/metrics/HoodieMetricsConfig.java:
##########
@@ -109,6 +109,17 @@ public class HoodieMetricsConfig extends HoodieConfig {
.sinceVersion("0.13.0")
.withDocumentation("Enable metrics for locking infra. Useful when
operating in multiwriter mode");
+ public static final ConfigProperty<Boolean> RLI_LOOKUP_METRICS_ENABLE =
ConfigProperty
+ .key(METRIC_PREFIX + ".rli.lookup.enable")
+ .defaultValue(true)
Review Comment:
Two precedents for the default. `EMBED_ENGINE_PROPERTIES_IN_COMMIT_METADATA`
(`CommitMetadataProperties:80-88`) defaults to `false` "since these add
per-commit growth to the timeline", and the sibling `LOCK_METRICS_ENABLE`
(L99-108) inherits from `hoodie.metrics.on` via `withInferFunction` rather than
standing alone. Default-on here also makes the RLI registry the first thing in
`DISTRIBUTED_REGISTRY_MAP` without opt-in (see the `resolveBundle` comment).
Could the default be `false` for the first release, or at least infer from
`TURN_METRICS_ON`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
