mailtoboggavarapu-coder commented on PR #19741: URL: https://github.com/apache/hudi/pull/19741#issuecomment-5419644910
Pinging for committer approval. This PR fixes a `CuratorFramework` resource leak in `BaseZookeeperBasedLockProvider.close()` — if `lock.release()` throws, the `curatorFrameworkClient.close()` call is skipped entirely, leaving ZooKeeper sessions open until they timeout (30–60 s each). In multi-writer deployments, accumulated leaked sessions can exhaust ZooKeeper's connection limit and bring down distributed locking for the entire data platform. The fix moves `curatorFrameworkClient.close()` into a `finally` block so it is always called regardless of whether lock release succeeds or throws. Single structural change, no logic change. [@danny0405](https://github.com/danny0405) [@yihua](https://github.com/yihua) [@vinothchandrasekar](https://github.com/vinothchandrasekar) [@nsivabalan](https://github.com/nsivabalan) — would appreciate a review and merge when you get a chance. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
