fhan688 commented on code in PR #19728:
URL: https://github.com/apache/hudi/pull/19728#discussion_r3862933027
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##########
@@ -149,6 +150,8 @@ public class StreamWriteFunction extends
AbstractStreamWriteFunction<HoodieFlink
protected transient MemorySegmentPool memorySegmentPool;
Review Comment:
> Do we still need to keep `memorySegmentPool`, seems we can use
`preemptiveMemorySegmentPool` throughout.
Good point. Both fields referenced the same wrapped pool after
initialization.
I removed `memorySegmentPool` and now use `preemptiveMemorySegmentPool`
throughout, including buffer creation, owner tracking, cleanup, and the test
accessor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
