voonhous commented on code in PR #19575: URL: https://github.com/apache/hudi/pull/19575#discussion_r3863057489
########## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/RliLookupMetricsTestBase.scala: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.functional + +import org.apache.hudi.DataSourceWriteOptions +import org.apache.hudi.common.config.HoodieMetadataConfig +import org.apache.hudi.common.metrics.Registry +import org.apache.hudi.config.HoodieIndexConfig +import org.apache.hudi.metrics.RecordIndexMetricNames + +import scala.collection.JavaConverters._ + +/** + * Shared plumbing for the record level index lookup metric tests: index selection, and reading the counters back the way an operator would -- off the la + */ +abstract class RliLookupMetricsTestBase extends RecordLevelIndexTestBase { Review Comment: Two of the seven are in. Of the rest, the MOR twins are the cheapest: nothing under `RecordIndexLookupMetrics`, `ExecutorMetrics`, `DistributedRegistry` or the two lookup functions branches on table type, and both table types reach the drain through the same `commitStats`, so they re-run 22 writes over identical lines. The multi-table class now separates gauges by `METRICS_REPORTER_PREFIX`, which is the table name, so it still cannot exercise the digest (`countersAreScopedByBasePathNotOnlyByTableName` does). Could those two go now, leaving the partitioned twins until the lifetime settles? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
