hudi-agent commented on code in PR #19760:
URL: https://github.com/apache/hudi/pull/19760#discussion_r3864254559
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestAvroKafkaSource.java:
##########
@@ -151,6 +159,31 @@ void sendMessagesToKafkaWithNullKafkaValue(String topic,
int count, int numParti
}
Review Comment:
🤖 nit: could you avoid the nullable sentinel here? When reading
`sendUserRecordsWithConfluentSerializer(topic, registryUrl, simpleSchema, 5,
null)` at the call-site it's not obvious what `null` signals without jumping to
the signature — two small helpers or always populating the field with a default
would keep the call-sites self-documenting.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
