danny0405 commented on a change in pull request #2745:
URL: https://github.com/apache/hudi/pull/2745#discussion_r604647518
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##########
@@ -180,28 +180,34 @@ public IOType getIOType() {
fileWriter.close();
HoodieWriteStat stat = new HoodieWriteStat();
- stat.setPartitionPath(writeStatus.getPartitionPath());
- stat.setNumWrites(recordsWritten);
- stat.setNumDeletes(recordsDeleted);
- stat.setNumInserts(insertRecordsWritten);
- stat.setPrevCommit(HoodieWriteStat.NULL_COMMIT);
- stat.setFileId(writeStatus.getFileId());
- stat.setPath(new Path(config.getBasePath()), path);
long fileSizeInBytes = FSUtils.getFileSize(fs, path);
stat.setTotalWriteBytes(fileSizeInBytes);
stat.setFileSizeInBytes(fileSizeInBytes);
- stat.setTotalWriteErrors(writeStatus.getTotalErrorRecords());
Review comment:
The only difference between `HoodieCreateHandle` and `FlinkCreateHandle`
is how they fetch the fize size, can we extract that part out ? Because usually
we override the different part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
