lokeshj1703 commented on code in PR #19717:
URL: https://github.com/apache/hudi/pull/19717#discussion_r3872195582
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -435,8 +453,16 @@ private void initializeMetadataPartition(
Indexer indexer,
String dataTableInstantTime,
Map<String, List<FileInfo>> partitionToAllFilesMap,
- Lazy<List<FileSliceAndPartition>> lazyMergedFileSlices) throws
IOException {
- String instantTimeForPartition =
generateUniqueInstantTime(dataTableInstantTime);
+ Lazy<List<FileSliceAndPartition>> lazyMergedFileSlices,
+ Option<String> requestedIndexPartition) throws IOException {
Review Comment:
Rename to requestedIndexPartitionOpt
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -830,15 +875,25 @@ public void buildMetadataPartitions(HoodieEngineContext
engineContext, List<Hood
if (!enabledIndexerMap.containsKey(partitionType)) {
throw new HoodieIndexException(String.format("Indexing for metadata
partition: %s is not enabled", partitionType));
}
- partitionTypes.add(partitionType);
- partitionPaths.add(relativePartitionPath);
+ if (partitionType == SECONDARY_INDEX || partitionType ==
EXPRESSION_INDEX) {
+ String previous = requestedPartitionPaths.put(partitionType,
relativePartitionPath);
Review Comment:
This suggests we only support one partition per partition type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
