rangareddy commented on code in PR #19463: URL: https://github.com/apache/hudi/pull/19463#discussion_r3888333975
########## hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/utils/TestHoodieRealtimeRecordReaderUtils.java: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.hadoop.utils; + +import org.apache.hudi.exception.HoodieException; + +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Collections; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * Tests {@link HoodieRealtimeRecordReaderUtils#orderFields}, which maps Hive's + * {@code hive.io.file.readcolumn.names} and {@code hive.io.file.readcolumn.ids} onto an ordered + * projection list. + */ +public class TestHoodieRealtimeRecordReaderUtils { + + @Test + public void testOrderFieldsSortsNamesByTheirHivePosition() { + assertEquals(Arrays.asList("rider", "driver", "fare"), + HoodieRealtimeRecordReaderUtils.orderFields("driver,fare,rider", "1,2,0", Collections.emptyList())); + } + + @Test + public void testOrderFieldsReturnsEmptyForEmptyInput() { + assertEquals(Collections.emptyList(), + HoodieRealtimeRecordReaderUtils.orderFields("", "", Collections.emptyList())); + } + + /** + * Hive can repeat a name in the read-column list while keeping ids unique, which the method + * deliberately tolerates by de-duplicating both sides before pairing them. + */ + @Test + public void testOrderFieldsDeduplicatesRepeatedNames() { + assertEquals(Arrays.asList("rider", "driver"), + HoodieRealtimeRecordReaderUtils.orderFields("rider,driver,rider", "0,1", Collections.emptyList())); Review Comment: Done, both moved off the tail: "rider,rider,driver" against "0,1" on the name side and "0,0,1" on the id side. Added a javadoc line on why the position matters so it does not get moved back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
