liujinhui1994 commented on a change in pull request #2438:
URL: https://github.com/apache/hudi/pull/2438#discussion_r605394316
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -247,6 +266,32 @@ private Long delayOffsetCalculation(Option<String>
lastCheckpointStr, Set<TopicP
return delayCount;
}
+ /**
+ * Get the checkpoint by timestamp.
+ * @param consumer
+ * @param topicName
+ * @param timestamp
+ * @return
+ */
+ private String getOffsetsByTimestamp(KafkaConsumer consumer,
List<PartitionInfo> partitionInfoList, String topicName, Long timestamp) {
Review comment:
When the implementation plan is confirmed, I will quickly add test
When the program is confirmed, I will quickly add test
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -247,6 +266,32 @@ private Long delayOffsetCalculation(Option<String>
lastCheckpointStr, Set<TopicP
return delayCount;
}
+ /**
+ * Get the checkpoint by timestamp.
+ * @param consumer
+ * @param topicName
+ * @param timestamp
+ * @return
+ */
+ private String getOffsetsByTimestamp(KafkaConsumer consumer,
List<PartitionInfo> partitionInfoList, String topicName, Long timestamp) {
Review comment:
When the program is confirmed, I will quickly add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
