yihua opened a new pull request, #19830:
URL: https://github.com/apache/hudi/pull/19830

   ### Describe the issue this Pull Request addresses
   
   Closes #19829
   
   ### Summary and Changelog
   
   `HiveTestService` imports `TFramedTransport` from the package libthrift 
moved it out of in 0.14, while its `TServerSocketKeepAlive` overrides 
`TServerTransport.accept()`, which is `final` below 0.14. No single libthrift 
version satisfies both, and no method is overridable across both generations.
   
   Points the import at `org.apache.thrift.transport.layered.TFramedTransport`, 
and moves the `libthrift` test dependency in `hudi-hive-sync` and 
`hudi-utilities` from `${thrift.version}` (0.13.0, which the metaserver needs) 
to the existing `${hive.libthrift.version}` (0.14.1), which already models the 
thrift the Hive client is compiled against.
   
   ### Impact
   
   Test scope only. The build currently resolves a 0.14-era transport package 
from the full `hive-exec`, so behaviour there is unchanged; consumers of the 
`hudi-hive-sync` tests jar on a classpath using `hive-exec:core` can now load 
the class at all.
   
   ### Risk Level
   
   low
   
   `ChainedTTransportFactory.getTransport` already declares the 
`TTransportException` that 0.14 adds to `TTransportFactory.getTransport`, so no 
call site changes. `hudi-hive-sync` and `hudi-utilities` both `test-compile` 
cleanly on JDK 11.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to