hudi-agent commented on code in PR #19488:
URL: https://github.com/apache/hudi/pull/19488#discussion_r3927501286
##########
hudi-aws/src/test/java/org/apache/hudi/aws/sync/TestAWSGlueSyncClient.java:
##########
@@ -200,6 +205,47 @@ void testCreateOrReplaceTable_TableDoesNotExist() {
verify(mockAwsGlue, times(1)).createTable(any(CreateTableRequest.class));
}
+ /**
+ * Thread on #19488: HiveSyncTool.syncHoodieTable runs syncFirstTime without
syncSchema, so a table
+ * created with empty comments would only pick them up on the second sync.
createTable therefore has to
+ * carry the docs itself, gated on hoodie.datasource.hive_sync.sync_comment.
+ */
+ @Test
+ void testCreateTableCarriesColumnCommentsOnTheFirstSync() {
+ String tableName = "testTable";
+ HoodieSchema storageSchema = GlueTestUtil.getSimpleSchema();
Review Comment:
🤖 This test fails as written — I ran the class and it errors with `expected:
<the person's name> but was: <>`. `createTable` gates the doc lookup on
`HIVE_SYNC_COMMENT` (default `false`), and neither this test nor
`GlueTestUtil.setUp()` enables it, so the `name` column is created with an
empty comment. Could you set `hoodie.datasource.hive_sync.sync_comment=true` in
the test props (or the fixture) so it actually exercises the new branch?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
