cshuo commented on code in PR #19804:
URL: https://github.com/apache/hudi/pull/19804#discussion_r3930294570
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java:
##########
@@ -214,4 +217,14 @@ public HoodieSchema
constructHiveOrderedSchema(HoodieSchema writerSchema, Map<St
protected HoodieSchema getLogScannerReaderSchema() {
return usesCustomPayload ? writerSchema : readerSchema;
}
+
+ /**
+ * Creates a reader context using the table configuration and the complete
Hadoop runtime configuration.
+ */
+ protected HoodieReaderContext<IndexedRecord> createReaderContext() {
+ TypedProperties readerProps =
TypedProperties.copy(metaClient.getTableConfig().getProps(true));
Review Comment:
`getProps(true)` already returns a fresh `TypedProperties` containing global
and table properties, so the extra `TypedProperties.copy(...)` is unnecessary.
Could we remove it here and at the other reader-context construction sites in
this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
