yihua opened a new pull request, #747:
URL: https://github.com/apache/hudi-rs/pull/747
## Description
Follow-up to #718, from running the environment report on a Graviton
instance.
The CPU read as `unknown x 16`: aarch64 `/proc/cpuinfo` carries no model
name, only implementer and part numbers, and the `lscpu` fallback only ran
after that first read. It now asks `lscpu` first and falls back to the machine
type, so neither architecture reports unknown.
The report also printed the full data URL, bucket included. It is meant to
be pasted alongside published numbers, so it now reports the scheme and omits
the bucket.
Two smaller things while here: the `RUSTFLAGS` placeholder used angle
brackets, which do not survive being pasted into a comment, and the report did
not say how many cores Spark's `local[*]` master actually expands to, which is
the first thing a reader asks of a single-node comparison.
## How are the changes test-covered
- [ ] N/A
- [ ] Automated tests (unit and/or integration tests)
- [x] Manual tests
- [x] Details are described below
Ran `generate`, `create-tables`, `bench-datafusion` and `compare` at SF1 and
read back the printed report: CPU and core count populated, `spark master:
local[*] on 14 cores` present, and the `RUSTFLAGS` placeholder rendering
literally. Checked the bucket omission and the unset-`RUSTFLAGS` default
against both a cloud URL and a local path. `shellcheck` is clean.
The aarch64 path is the one this fixes and cannot be exercised on macOS; the
ordering change makes `lscpu` the primary source on both, and `lscpu` reports
`Model name` on x86 and aarch64 alike.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
