voonhous commented on code in PR #19657:
URL: https://github.com/apache/hudi/pull/19657#discussion_r3941466101
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -50,7 +50,7 @@ import org.apache.hudi.util.JFunction
import org.apache.hadoop.fs.FileSystem
import org.apache.spark.sql.{DataFrame, DataFrameWriter, Dataset, Encoders,
Row, SaveMode, SparkSession, SparkSessionExtensions}
import org.apache.spark.sql.execution.datasources.{HadoopFsRelation,
LogicalRelation}
-import org.apache.spark.sql.functions.{col, concat, lit, udf, when}
+import org.apache.spark.sql.functions.{col, concat, date_format, lit, udf,
when}
Review Comment:
**nit:** feel free to ignore. `date_format` is left over from the removed
derived columns and is now unused - the only other matches in this file are the
local `udf_date_format` vals. `DateTimeZone` and `TimeZone` were both cleaned
up in 4eab0eb9, so this looks like a miss rather than intent. No build impact:
scalastyle has no unused-import check and there is no `-Xfatal-warnings`.
```suggestion
import org.apache.spark.sql.functions.{col, concat, lit, udf, when}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
