voonhous commented on PR #19850: URL: https://github.com/apache/hudi/pull/19850#issuecomment-5559548912
@anshulsingh-py Thanks for raising this. The latest revision shares `bindAndResolveExpression` between validation and evaluation, so there’s no separate allowlist to keep consistent. You’re right that calling `evaluateFilter()` directly without validation still permits silent row drops. Callers currently need to validate first; making that contract harder to misuse would be a useful follow-up. The `FunctionRegistry` fallback would expand the supported function set, which is worth reviewing separately with compatibility tests. This PR looks good to me for rejecting unsupported procedure filters early. I’m happy to approve once CI passes; let’s keep the broader function support in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
