HuangZhenQiu commented on code in PR #19844:
URL: https://github.com/apache/hudi/pull/19844#discussion_r3946666550
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -425,8 +425,8 @@ private static DataStream<HoodieFlinkInternalRow>
streamBootstrap(
boolean bounded) {
DataStream<HoodieFlinkInternalRow> dataStream1 =
rowDataToHoodieRecord(conf, rowType, dataStream);
- boolean isGlobalRLI = OptionsResolver.isGlobalRecordLevelIndex(conf);
- if (conf.get(FlinkOptions.INDEX_BOOTSTRAP_ENABLED) || (bounded &&
!isGlobalRLI)) {
+ boolean isRLI = OptionsResolver.isGlobalRecordLevelIndex(conf) ||
OptionsResolver.isRecordLevelIndex(conf);
Review Comment:
Make sense. It has better branch condition and easier to maintain. Added
corresponding comments on each branch also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
