cshuo commented on code in PR #19842:
URL: https://github.com/apache/hudi/pull/19842#discussion_r3947924913
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/VectorColumnParser.java:
##########
@@ -69,8 +68,7 @@ public static Map<String, Integer> parse(String
vectorColumns) {
"Invalid VECTOR column descriptor '" + entry + "'. Expected
format: columnName[:dimension].");
}
String columnName = parts[0].trim();
- String normalizedColumnName = columnName.toLowerCase(Locale.ROOT);
- if (parsed.containsKey(normalizedColumnName)) {
+ if (parsed.containsKey(columnName)) {
Review Comment:
This is intentional. HoodieHiveCatalog#getTable uses the Hudi schema, which
falls back from commit metadata to the table create schema and then the
data-file schema. HMS schema is used only when no Hudi schema can be resolved,
so the first-insert scenario should retain the table create schema. If HMS
casing differs in the fallback path, that is a broader field-name issue rather
than VECTOR-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
