voonhous commented on code in PR #19849:
URL: https://github.com/apache/hudi/pull/19849#discussion_r3951324144
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala:
##########
@@ -100,7 +100,7 @@ class HoodieMergeOnReadRDDV2(@transient sc: SparkContext,
fileReaders: HoodieMergeOnReadBaseFileReaders,
tableSchema: HoodieTableSchema,
requiredSchema: HoodieTableSchema,
- tableState: HoodieTableState,
+ latestCommitTimestamp: Option[String],
Review Comment:
**nit:** Revisiting this: the empty-timeline case we reasoned about is
unreachable through these relations. `DefaultSource.scala:332` short-circuits a
table with zero completed instants to `EmptyRelation` before any MOR relation
is built (`f7a77961e365`, HUDI-1850).
Keeping `Option[String]` is still right, just because it is the type
`tableState.latestCommitTimestamp` had. No change needed -- flagging so the
rationale on this thread does not get quoted later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
