cshuo commented on code in PR #19858:
URL: https://github.com/apache/hudi/pull/19858#discussion_r3953997416
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -361,7 +361,7 @@ public static HoodieTableMetaClient initTableIfNotExists(
.setUrlEncodePartitioning(conf.get(FlinkOptions.URL_ENCODE_PARTITIONING))
.setCDCEnabled(conf.get(FlinkOptions.CDC_ENABLED))
.setCDCSupplementalLoggingMode(conf.get(FlinkOptions.SUPPLEMENTAL_LOGGING_MODE))
- .setPopulateMetaFields(OptionsResolver.isPopulateMetaFields(conf))
+ .setMetaFieldsMode(OptionsResolver.getMetaFieldsMode(conf))
.initTable(HadoopFSUtils.getStorageConfWithCopy(hadoopConf),
basePath);
Review Comment:
Could we reject MOR + selective metadata modes before initializing the
table? Currently, the unsupported mode is persisted before write-client
validation fails; the catalog creation path skips that validation entirely.
This leaves a table that requires configuration repair or recreation before it
can be written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
