voonhous commented on code in PR #19863:
URL: https://github.com/apache/hudi/pull/19863#discussion_r3954793067
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/HudiPredicates.java:
##########
@@ -29,6 +29,10 @@ public class HudiPredicates
public static HudiPredicates from(TupleDomain<ColumnHandle> predicate)
{
+ if (predicate.isNone()) {
+ return new HudiPredicates(TupleDomain.none(), TupleDomain.none());
Review Comment:
Agreed that the hypothetical path described in Impact would still fail at
computeEnforced. My intent here is upstream parity and defensive handling of an
otherwise unreachable input, since the planner short-circuits before
applyFilter today. I'll narrow the Impact wording to avoid claiming end-to-end
support for passing none() through applyFilter.
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/HudiPredicates.java:
##########
@@ -29,6 +29,10 @@ public class HudiPredicates
public static HudiPredicates from(TupleDomain<ColumnHandle> predicate)
{
+ if (predicate.isNone()) {
+ return new HudiPredicates(TupleDomain.none(), TupleDomain.none());
Review Comment:
Agreed that the hypothetical path described in Impact would still fail at
computeEnforced. My intent here is upstream parity and defensive handling of an
otherwise unreachable input, since the planner short-circuits before
`applyFilter` today. I'll narrow the Impact wording to avoid claiming
end-to-end support for passing `none()` through applyFilter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
