anshulsingh-py commented on PR #19853: URL: https://github.com/apache/hudi/pull/19853#issuecomment-5587732834
Good catch — that was a real bug, not just a nit. Confirmed empirically: `instr(upper(name), 'A')` and `concat(upper(name), 'x')` were both getting rejected as unsupported even though both functions individually resolve fine, because function resolution ran top-down (`transform`) — the outer call's argument was still an `UnresolvedFunction` when the new `resolved`/`checkInputDataTypes` guard checked it. Switched to `transformUp` so children resolve before their parent is checked. Added test coverage for both cases. Also dropped the leftover duplicate comment. Full `procedure` package suite: 261/261 passing, BUILD SUCCESS (the previously-seen 4 unrelated `hudi-cli`/bootstrap failures are gone too — confirmed stale local artifact, not a real issue). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
