hudi-agent commented on code in PR #19853: URL: https://github.com/apache/hudi/pull/19853#discussion_r3961294113
########## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/HoodieProcedureFilterUtils.scala: ########## Review Comment: 🤖 **Line 433:** Since this type check runs in pass two but the widening pass runs afterwards, does `nvl(ts, 0)` now get rejected while the equivalent `coalesce(ts, 0)` (hardcoded, then widened by `applyCoalesceTypeCoercion`) still works? Deferring the `checkInputDataTypes` verdict to after the coercion pass would keep the two consistent. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
