voonhous commented on code in PR #19865:
URL: https://github.com/apache/hudi/pull/19865#discussion_r3964820002
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/util/TestClusteringUtils.java:
##########
@@ -182,7 +180,7 @@ public void testClusteringPlanInflight() throws Exception {
fileIds1.add(UUID.randomUUID().toString());
String clusterTime1 = "1";
HoodieInstant requestedInstant =
createRequestedClusterInstant(partitionPath1, clusterTime1, fileIds1);
- HoodieInstant inflightInstant =
metaClient.getActiveTimeline().transitionReplaceRequestedToInflight(requestedInstant,
Option.empty());
+ HoodieInstant inflightInstant =
metaClient.getActiveTimeline().transitionClusterRequestedToInflight(requestedInstant,
Option.empty());
assertTrue(ClusteringUtils.isClusteringInstant(metaClient.getActiveTimeline(),
requestedInstant, INSTANT_GENERATOR));
Review Comment:
Addressed in 51454e819891: the test is now parameterized over table version.
The version-6 lane goes through `replacecommit.requested/inflight`, so both
`isClusteringInstant` asserts take the `REPLACE_COMMIT` arm, and
`createRequestedClusterInstant` picks the action the way
`ClusteringPlanActionExecutor` does. 12 run, 0 skipped locally with checkstyle
on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
