voonhous commented on code in PR #19855:
URL: https://github.com/apache/hudi/pull/19855#discussion_r3965110548
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaRepair.java:
##########
@@ -249,8 +250,7 @@ public static boolean hasTimestampMillisField(HoodieSchema
tableSchema) {
return hasTimestampMillisField(tableSchema.getNonNullType());
case TIMESTAMP:
- HoodieSchema.Timestamp timestampType = (HoodieSchema.Timestamp)
tableSchema;
- return timestampType.getPrecision() ==
HoodieSchema.TimePrecision.MILLIS;
+ return HoodieTableMetadataUtil.isTimestampMillisField(tableSchema);
Review Comment:
Addressed in 9cb20ca8 -- `isTimestampMillisField` now lives in
`HoodieSchemaUtils` and `HoodieTableMetadataUtil` delegates to it, so
`common.schema` no longer imports anything from `org.apache.hudi.metadata`.
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaRepair.java:
##########
@@ -249,8 +250,7 @@ public static boolean hasTimestampMillisField(HoodieSchema
tableSchema) {
return hasTimestampMillisField(tableSchema.getNonNullType());
case TIMESTAMP:
- HoodieSchema.Timestamp timestampType = (HoodieSchema.Timestamp)
tableSchema;
- return timestampType.getPrecision() ==
HoodieSchema.TimePrecision.MILLIS;
+ return HoodieTableMetadataUtil.isTimestampMillisField(tableSchema);
Review Comment:
Done in 9cb20ca8: the method moved down into `HoodieSchemaUtils` and
`HoodieTableMetadataUtil` delegates, so the edge now runs metadata -> schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
