hudi-agent commented on code in PR #19866: URL: https://github.com/apache/hudi/pull/19866#discussion_r3975169645
########## packaging/hudi-flink-bundle/README.md: ########## @@ -0,0 +1,40 @@ +<!-- +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +--> + +# `hudi-flink-bundle` module + +This module packages the Hudi Flink bundle for reading and writing Hudi tables with Flink. + +## Lance dependencies + +The Hudi Flink bundle does not include Lance runtime dependencies. To use Lance with Hudi, +ensure that the Flink runtime includes the following dependencies. + +| Dependency | Version | +|------------|---------| +| `org.lance:lance-core` | 4.0.0 | +| `org.apache.arrow:arrow-vector` | 18.3.0 | Review Comment: 🤖 These versions duplicate the root pom's `${lance.version}` / `${arrow.version}` properties (and Arrow's own transitive netty/flatbuffers pins), so they'll silently go stale on the next bump. Might be worth referencing the pom properties instead of hardcoding, or adding a note pointing to the root pom as the source of truth. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## packaging/bundle-validation/validate.sh: ########## Review Comment: 🤖 Since the PR was rewound to docs-only, the bundle-validation Lance additions are no longer in the diff, so nothing in CI pins this list anymore. Worth keeping in mind that the README hardcodes 4.0.0/18.3.0, which are `${lance.version}`/`${arrow.version}` in the root pom (L263-264), and netty/flatbuffers/jar-jni are just arrow's transitives — a version bump would silently make the table wrong. Could the doc point at those properties instead of repeating the numbers? ########## packaging/hudi-flink-bundle/README.md: ########## @@ -0,0 +1,40 @@ +<!-- +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +--> + +# `hudi-flink-bundle` module + +This module packages the Hudi Flink bundle for reading and writing Hudi tables with Flink. + +## Lance dependencies + +The Hudi Flink bundle does not include Lance runtime dependencies. To use Lance with Hudi, +ensure that the Flink runtime includes the following dependencies. + +| Dependency | Version | +|------------|---------| +| `org.lance:lance-core` | 4.0.0 | Review Comment: 🤖 Was this list validated as sufficient end-to-end? `lance-core` 4.0.0 also declares `arrow-dataset`, `lance-namespace-core`, `lance-namespace-apache-client`, `guava`, `commons-lang3` and `jackson-databind` at compile scope, and unlike the POM comment the README doesn't carry the "plus required transitive dependencies" caveat — so a user copying the table exactly could still hit a `NoClassDefFoundError`. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
