voonhous commented on PR #19889: URL: https://github.com/apache/hudi/pull/19889#issuecomment-5617765425
> shoude be by design, the pattern is introducing a common interface then duplicate the impls, so that it is more easier to drop these logics when moving forward. The cost of maintaining looks okay since the evolving itself is quite slow and we just got two copies. I don't quite understand the argument here. If V1 needs to be dropped, the whole class can be removed even with the refactor without issue. Also, flattening both into each class means the second question can only be answered by diffing ~200 lines. With a skeletal base, the version class contains nothing but the delta, so the per-version mapping becomes more visible, not less. This improves code readability, easier to review if we're not using LLM assisted reviews and also copy-paste errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
